perf: skip Discovered messages during test execution #4313
Merged
+8
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove Discovered message loop from HandleRunRequestAsync - Only send Discovered messages during discovery requests - Change DynamicTestQueue.EnqueueAsync to sync Enqueue - Dynamic tests created at runtime don't need discovery notifications This saves time and allocations when running tests since Discovered messages are only needed for test explorer discovery, not execution. Co-Authored-By: Claude Opus 4.5 <[email protected]>
thomhurst
temporarily deployed
to
Pull Requests
GitHub Actions
Inactive
thomhurst
temporarily deployed
to
Pull Requests
GitHub Actions
Inactive
thomhurst
had a problem deploying
to
Pull Requests
GitHub Actions
Failure
Owner
Author
SummaryRemoves unnecessary Discovered message overhead during test execution by skipping these notifications when running tests (they remain for discovery requests). Critical IssuesNone found ✅ SuggestionsNone - the change is clean and well-reasoned:
Verdict✅ APPROVE - No critical issues This is a solid performance optimization that removes unnecessary work during test execution while preserving correct behavior for test discovery. |
This was referenced Jan 12, 2026
Merged
This was referenced Jan 13, 2026
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
HandleRunRequestAsyncduring test executionDynamicTestQueue.EnqueueAsyncto synchronousEnqueuemethodRationale
Discovered messages are used by test explorers to populate their UI during test discovery. When actually running tests, these messages are unnecessary overhead since:
CreateTestVariantorAddDynamicTest) are created during execution, not discoveryTest plan
🤖 Generated with Claude Code